Fix multichain keybundle #14369
Merged
Fix multichain keybundle #14369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested review from
EasterTheBunny
and removed request for
a team
|
I see you updated files related to |
archseer
force-pushed
the
fix-multichain-keybundle
branch
2 times, most recently
from
b1cecd5 to
256f0c2
Compare
| transmitters = append(transmitters, a) | ||
| } | ||
|
|
||
| return ocr3CapabilityConfigDigest( |
There was a problem hiding this comment.
@archseer This shouldn't panic if we can avoid it, especially if the caller can return an error
There was a problem hiding this comment.
I copied that straight from libocr's evmutils and changed the signers type parameter, I assume it's panicking since it should really be a compile time check. If the digest size changed we can't recover from that
cedric-cordenier
previously approved these changes
Sep 9, 2024
archseer
force-pushed
the
fix-multichain-keybundle
branch
from
256f0c2 to
fea5866
Compare
DeividasK
previously approved these changes
Sep 10, 2024
archseer
force-pushed
the
fix-multichain-keybundle
branch
3 times, most recently
from
5fcb275 to
8a5a6d4
Compare
app-token-issuer-infra-releng
bot
requested review from
a team,
RensR,
matYang and
RayXpub
as code owners
archseer
force-pushed
the
fix-multichain-keybundle
branch
from
e9b4b43 to
0930f22
Compare
|
cedric-cordenier
approved these changes
Sep 17, 2024
smickovskid
approved these changes
Sep 17, 2024
vyzaldysanchez
approved these changes
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.