Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm 3 method for installing crds #169

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use Helm 3 method for installing crds
This commit resolves a registration issue with step-issuer CRDs when
a stepIssuer is installed at the same time.

This commit moves the CRDs from an included dependency chart to the new
crds directory supported by Helm 3. See:
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

Fixes #168
  • Loading branch information
maraino committed Jan 11, 2024
commit 521de1b67ff8eb308c1762321d61a4e413ded3e5
6 changes: 1 addition & 5 deletions step-issuer/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
apiVersion: v2
name: step-issuer
type: application
version: 0.8.0+2
version: 1.8.0
appVersion: 0.8.0
description: Step-issuer helm chart for kubernetes.
home: https://smallstep.com
dependencies:
- name: crds
condition: crds.enabled
version: 0.8.0+2
keywords:
- authority
- ca
Expand Down
14 changes: 0 additions & 14 deletions step-issuer/charts/crds/Chart.yaml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.10.0
creationTimestamp: null
name: stepclusterissuers.certmanager.step.sm
spec:
group: certmanager.step.sm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.10.0
creationTimestamp: null
name: stepissuers.certmanager.step.sm
spec:
group: certmanager.step.sm
Expand Down
3 changes: 0 additions & 3 deletions step-issuer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,3 @@ tolerations: []

# affinity contains the affinity settings for pod assignment.
affinity: {}

crds:
enabled: true