Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm 3 method for installing crds #169

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

maraino
Copy link
Collaborator

@maraino maraino commented Jan 11, 2024

This commit resolves a registration issue with step-issuer CRDs when a stepIssuer is installed at the same time.

This commit moves the CRDs from an included dependency chart to the new crds directory supported by Helm 3. See:
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

Fixes #168

This commit resolves a registration issue with step-issuer CRDs when
a stepIssuer is installed at the same time.

This commit moves the CRDs from an included dependency chart to the new
crds directory supported by Helm 3. See:
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/

Fixes #168
@maraino maraino requested a review from a team as a code owner January 11, 2024 20:29
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jan 11, 2024
@maraino maraino requested review from dopey and removed request for a team January 11, 2024 20:30
@maraino maraino merged commit 4f5ec6c into master Jan 11, 2024
5 checks passed
@maraino maraino deleted the mariano/step-issuer-crds branch January 11, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

step-issuer refuses to deploy if stepIssuer.create is set to true
2 participants