-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLSA v1: make v1.0 the default version #832
Conversation
- Make v1.0 the default nav version. - Update front page to link to v1.0. - Update redirects to point to v1.0. Note: This just sets the default version to v1.0. PR slsa-framework#829 marks it as Approved. Part of slsa-framework#513. Signed-off-by: Mark Lodato <lodato@google.com>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Mark Lodato <lodato@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This looks good! I noticed that there's only "previous page" and "next page" buttons at the bottoms of pages in the Understanding SLSA and Core Specification sections (not in Attestations or How To). Is that intended? |
It's not intended, but is a limitation of our current site layout. I think #728 would address that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Part of #513.
Imprortant: We will not merge this until after #829 (on Tuesday, April 18).
Note: This just sets the default version to v1.0. PR #829 marks it as Approved.