Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLSA v1: make v1.0 the default version #832

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

MarkLodato
Copy link
Member

@MarkLodato MarkLodato commented Apr 12, 2023

  • Make v1.0 the default nav version.
  • Update front page to link to v1.0.
  • Update redirects to point to v1.0.
  • Update "project status" on index and community to say that v1.0 is stable.

Part of #513.

Imprortant: We will not merge this until after #829 (on Tuesday, April 18).

Note: This just sets the default version to v1.0. PR #829 marks it as Approved.

- Make v1.0 the default nav version.
- Update front page to link to v1.0.
- Update redirects to point to v1.0.

Note: This just sets the default version to v1.0. PR slsa-framework#829 marks it as Approved.

Part of slsa-framework#513.

Signed-off-by: Mark Lodato <lodato@google.com>
@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit c70b5f7
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/6436cf393c428f0008d86438
😎 Deploy Preview https://deploy-preview-832--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Mark Lodato <lodato@google.com>
@MarkLodato MarkLodato requested a review from olivekl April 12, 2023 15:33
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivekl
Copy link
Contributor

olivekl commented Apr 12, 2023

This looks good!

I noticed that there's only "previous page" and "next page" buttons at the bottoms of pages in the Understanding SLSA and Core Specification sections (not in Attestations or How To). Is that intended?

@MarkLodato
Copy link
Member Author

I noticed that there's only "previous page" and "next page" buttons at the bottoms of pages in the Understanding SLSA and Core Specification sections (not in Attestations or How To). Is that intended?

It's not intended, but is a limitation of our current site layout. I think #728 would address that.

@MarkLodato MarkLodato marked this pull request as ready for review April 17, 2023 12:22
@MarkLodato MarkLodato requested a review from a team April 17, 2023 12:23
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MarkLodato MarkLodato merged commit 4d7f142 into slsa-framework:main Apr 18, 2023
@MarkLodato MarkLodato deleted the v1-as-default branch April 18, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants