SLSA v1: Mark as Approved specification #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
lehors
reviewed
Apr 12, 2023
lehors
reviewed
Apr 12, 2023
lehors
reviewed
Apr 12, 2023
lehors
reviewed
Apr 12, 2023
lehors
reviewed
Apr 12, 2023
lehors
reviewed
Apr 12, 2023
Yes. I am working on a separate PR for that, which is much bigger. I wanted to separate out the Approval (which is codified in our governance) from changing the default (which is not). |
joshuagl
approved these changes
Apr 12, 2023
- Mark SLSA v1.0, Provenance v1, and VSA v1 as Approved. - Mark release candidates as Retired and hide them from the dropdown. - Remove `?draft` from `predicateType`. Note: This only marks v1.0 as Approved. A separate PR will set the default to v1.0. Signed-off-by: Mark Lodato <lodato@google.com>
Signed-off-by: Mark Lodato <lodato@google.com>
MarkLodato
added a commit
to MarkLodato/slsa
that referenced
this pull request
Apr 12, 2023
- Make v1.0 the default nav version. - Update front page to link to v1.0. - Update redirects to point to v1.0. Note: This just sets the default version to v1.0. PR slsa-framework#829 marks it as Approved. Part of slsa-framework#513. Signed-off-by: Mark Lodato <lodato@google.com>
trishankatdatadog
approved these changes
Apr 17, 2023
arewm
approved these changes
Apr 17, 2023
melba-lopez
approved these changes
Apr 17, 2023
|
Merging now. Thanks all! |
chtiangg
pushed a commit
to chtiangg/slsa
that referenced
this pull request
May 22, 2023
SLSA v1: Mark as Approved specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?draftfrompredicateType.Part of #513.
Important: We cannot merge this until Tuesday, April 18, which is after the end of the mandatory two-week review period. In the meantime, please review and approve so that we can merge on the 18th.
Note: This just marks v1.0 as approved. PR #832 sets the default version to v1.0.