-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: draft release support #1882
Merged
ianlewis
merged 2 commits into
slsa-framework:main
from
developer-guy:feature/draft-release-support
Apr 3, 2023
Merged
feat: draft release support #1882
ianlewis
merged 2 commits into
slsa-framework:main
from
developer-guy:feature/draft-release-support
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-guy
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
March 27, 2023 20:05
Thanks! Can you:
|
ready for review @ianlewis |
Thanks! Could you add the We should also have a note in the CHANGELOG.md for the v1.6.0 release. |
Fixes #1476 Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
|
laurentsimon
approved these changes
Apr 3, 2023
ianlewis
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Ian Lewis <ianlewis@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with the generic builder and will continue with the others as well if you accept the solution:
Fixes #1476
I tried that in osv-scanner project and it worked:
PTAL @laurentsimon @asraa @ianlewis