Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: draft release support #1882

Merged
merged 2 commits into from
Apr 3, 2023
Merged

feat: draft release support #1882

merged 2 commits into from
Apr 3, 2023

Conversation

developer-guy
Copy link
Contributor

@developer-guy developer-guy commented Mar 27, 2023

I started with the generic builder and will continue with the others as well if you accept the solution:

Fixes #1476

I tried that in osv-scanner project and it worked:

PTAL @laurentsimon @asraa @ianlewis

@ianlewis
Copy link
Member

ianlewis commented Mar 28, 2023

Thanks! Can you:

  • Add draft-release to the Go builder?
  • Add draft-release to the docs for the generic generator
  • Add draft-release to the docs for the Go builder?
  • Add draft-release to the docs for the docker-based builder?
  • Add a note to the CHANGELOG.md?

@developer-guy developer-guy changed the title WIP: draft release support feat: draft release support Apr 2, 2023
@developer-guy
Copy link
Contributor Author

ready for review @ianlewis

@ianlewis
Copy link
Member

ianlewis commented Apr 3, 2023

Thanks! Could you add the draft-release input to the docs for the generic generator, docker based builder, and Go builder ?

We should also have a note in the CHANGELOG.md for the v1.6.0 release.

Fixes #1476

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy
Copy link
Contributor Author

  • Add draft-release to the docs for the generic generator
  • Add draft-release to the docs for the Go builder?
  • Add draft-release to the docs for the docker-based builder?
  • Add a note to the CHANGELOG.md?

Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis enabled auto-merge (squash) April 3, 2023 23:37
@ianlewis ianlewis merged commit 7edd74b into slsa-framework:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] support creating a draft release
3 participants