add draft-release support #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-guy
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
laurentsimon
reviewed
Apr 7, 2023
| ISSUE_REPOSITORY: slsa-framework/slsa-github-generator | ||
| # WARNING: update build job if CONFIG_FILE changes. | ||
| CONFIG_FILE: .github/configs-go/config-ldflags-tag.yml | ||
| DEFAULT_VERSION: v34.0.0 |
There was a problem hiding this comment.
please update to v35.0.0. We need unique versions for each e2e tests. v34.0.0 is already taken. You could not have know, we don't have documentation on this :-)
There was a problem hiding this comment.
I added some doc on DEFAULT_VERSION to the e2e tests' readme.
There was a problem hiding this comment.
thanks, this is really useful!
| run: | | ||
| set -euo pipefail | ||
|
|
||
| ./.github/workflows/scripts/e2e-create-release.sh |
There was a problem hiding this comment.
I think you need to update this file to mark the release as a draft in the API call.
There was a problem hiding this comment.
yes, I added draft release support into the script, thanks.
|
kindly ping @laurentsimon |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we merged slsa-framework/slsa-github-generator#1882, we need to test it requested by @ianlewis and @laurentsimon in slsa-framework/slsa-github-generator#1476. So, this PR aims to create a test for draft-release support.