-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add provenance-name to the outputs #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
- Can you add an note to the CHANGELOG.md for the new output?
- Can you add documention for the output to the README for the Go workflow?
PTAL @ianlewis |
@developer-guy oops, I think a commit may be missing! |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
is this necessary ? 🤔 |
because I updated the tests according to the changes to see whether it is working, and it worked. |
nope, I delete my comment. I mis-read ^^ |
You need to run the toc CLI as in the failing pre-submit in order to format the .md properly |
should work. Let me know. |
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I went ahead and made the changes based on @laurentsimon's comments since he went ahead and committed changes to our e2e tests.
Fixes #1842