Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] SLSA 3 Go Builder add provenance name to the workflow outputs #1842

Closed
developer-guy opened this issue Mar 18, 2023 · 2 comments · Fixed by #1844
Closed

[feature] SLSA 3 Go Builder add provenance name to the workflow outputs #1842

developer-guy opened this issue Mar 18, 2023 · 2 comments · Fixed by #1844
Assignees
@developer-guy
Labels
status:triage Issue that has not been triaged type:feature New feature or request

Comments

@developer-guy
Copy link
Contributor

developer-guy commented Mar 18, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
This is a feature.

Describe the solution you'd like

At the time of writing this, SLSA 3 Go Builder does not have the provenance name generated during the workflow within its outputs1. So, it'd be better to provide an output that specifies the provenance name.

Additional context
I'm willing to do this, please assign it to me. cc @laurentsimon

Footnotes

  1. https://github.com/slsa-framework/slsa-github-generator/blob/667cb7e0d6b66bd22435d20e23d9ecaf82bd7682/.github/workflows/builder_go_slsa3.yml#L82 ↩
@developer-guy developer-guy added status:triage Issue that has not been triaged type:feature New feature or request labels Mar 18, 2023
@developer-guy developer-guy mentioned this issue Mar 19, 2023
Merged
@laurentsimon
Copy link
Collaborator

Let's add e2e tests before closing this issue

@laurentsimon
Copy link
Collaborator

Added e2e tests in slsa-framework/example-package@7f8f39e. It's using go-provenance-name for consistency with the existing go-binary-name

ianlewis pushed a commit that referenced this issue Mar 22, 2023
@developer-guy
feat: add provenance-name to the outputs (#1844)
66b541d 
Fixes #1842

---------

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Co-authored-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@developer-guy developer-guy

Labels
status:triage Issue that has not been triaged type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add provenance-name to the outputs
2 participants
@developer-guy @laurentsimon