Docs: Fix <title> tag having docs version #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Jan 13, 2025
| @@ -31,10 +31,9 @@ export default defineConfig({ | |||
| }, | |||
| integrations: [ | |||
| starlight({ | |||
| title: "1.9.2", | |||
| title: "Slint Docs", | |||
There was a problem hiding this comment.
Please also adjust .github/workflows/upgrade_version.yaml to not touch this file anymore.
tronical
approved these changes
Jan 13, 2025
The version was being set not just as a visual title, but also as part of the meta tag for every page on the docs site. Which will then change for each release as the version number changes. Other sites have a static label here that is indepedent of the version e.g. Slint UI or Slint docs. 'Slint Docs' is now used.
NigelBreslaw
force-pushed
the
nigel/docs-title-seo
branch
from
cfbd384 to
ad7e8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version was being set not just as a visual title, but also as part of the meta tag for every page on the docs site. Which will then change for each release as the version number changes.
Other sites have a static label here that is indepedent of the version e.g. Slint UI or Slint docs. 'Slint Docs' is now used.