Skip to content

Commit

Permalink
Docs: Fix <title> tag having docs version (#7350)
Browse files Browse the repository at this point in the history
The version was being set not just as a visual title, but also as part of the meta tag for every page on the docs site. Which will then change for each release as the version number changes.

Other sites have a static label here that is independent of the version e.g. Slint UI or Slint docs. 'Slint Docs' is now used.
  • Loading branch information
NigelBreslaw authored Jan 13, 2025
1 parent 7056515 commit a390118
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/upgrade_version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
# The version is also in these files
sed -i "s/^version = \"[0-9]*\.[0-9]*\.[0-9]*\(.*\)\"/version = \"${{ github.event.inputs.new_version }}\1\"/" api/cpp/docs/conf.py api/python/pyproject.toml
sed -i 's/title: "[0-9]*\.[0-9]*\.[0-9]*"/title: "${{ github.event.inputs.new_version }}"/' docs/astro/astro.config.mjs
# Version in package.json files
git ls-files | grep package.json | xargs sed -i 's/"version": ".*"/"version": "${{ github.event.inputs.new_version }}"/'
Expand Down
5 changes: 2 additions & 3 deletions docs/astro/astro.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,9 @@ export default defineConfig({
},
integrations: [
starlight({
title: "1.10.0",
title: "Slint Docs",
logo: {
light: "./src/assets/slint-logo-simple-light.webp",
dark: "./src/assets/slint-logo-simple-dark.webp",
src: "./src/assets/slint-logo-small-light.svg",
},
customCss: ["./src/styles/custom.css", "./src/styles/theme.css"],

Expand Down
2 changes: 1 addition & 1 deletion docs/astro/src/styles/custom.css
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@

.site-title {
font-size: 1.3rem;
text-transform: uppercase;
color: #fff;
margin-top: -4px;
}

span {
Expand Down

0 comments on commit a390118

Please sign in to comment.