3.x - Code Quality #2671
Merged
3.x - Code Quality #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing `@throws` - Closes: slimphp#2666 - Format DocBlocks to be cohesive - Use imports instead of \ClassName - Line return after last `@param` and `@return` ``` use Exception; /** * @param ... * * @return ... * * @throws Exception */ ``` Closes slimphp#2668
…xception class for some reason even though it's in the imports?!? Reverting back to previous code to see if that fixes it.
…xception class for some reason even though it's in the imports?!? COMPLETE REVERT TO SEE IF THIS FIXES THINGS
Closed
l0gicgate
force-pushed
the
3.x-CodeQuality
branch
from
25e91da to
bb36dae
Compare
l0gicgate
force-pushed
the
3.x-CodeQuality
branch
3 times, most recently
from
4b47a13 to
b7f0e5f
Compare
l0gicgate
force-pushed
the
3.x-CodeQuality
branch
from
b7f0e5f to
90beff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a cohesive docblock usage, import usage and removes the copyright headers from all files.
Closes #2666 and #2670