Add missing @throws to docblocks #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: @return type in NotFound.php had wrong type in docblock (fixed)
l0gicgate
requested changes
Apr 26, 2019
There was a problem hiding this comment.
Can we import the exceptions at the top instead of using the \Exception annotation. I'd like to keep the doc blocs as cohesive as possible. Right now some have them and some don't. Also, put a line return after last @param and @return
use Exception;
/**
* @param ...
*
* @return ...
*
* @throws Exception
*/
RyanNerd
added a commit
to RyanNerd/Slim
that referenced
this pull request
Apr 27, 2019
- Add missing `@throws` - Closes: slimphp#2666 - Format DocBlocks to be cohesive - Use imports instead of \ClassName - Line return after last `@param` and `@return` ``` use Exception; /** * @param ... * * @return ... * * @throws Exception */ ``` Closes slimphp#2668
Closed
l0gicgate
approved these changes
Apr 27, 2019
l0gicgate
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: @return type in NotFound.php had wrong types in docblock (fixed)
Closes #2666