Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated tap functions #6

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Conversation

jozefizso
Copy link
Member

This PR is a back-port for the soldair#380

I replaced all the deprecated functions in tap tests. This keeps the tests output nice and tidy and it allows to upgrade to the latest tap release (v20 for NodeJS 18+, or v21 for NodeJS 20+) in the future.

Test report on master branch:

Suites:   ​33 passed​, ​33 of 33 completed
Asserts:  ​​​6187 passed​, ​of 6187
​Time:​   ​3s

Test report after replacing deprecated functions:

Suites:   ​33 passed​, ​33 of 33 completed
Asserts:  ​​​6187 passed​, ​of 6187
​Time:​   ​2s

@jozefizso jozefizso self-assigned this Oct 13, 2024
@jozefizso jozefizso merged commit 5aaf7d5 into main Oct 13, 2024
2 of 4 checks passed
@jozefizso jozefizso added this to the v2.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant