Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated tap functions #380

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace deprecated tap functions #380

wants to merge 5 commits into from

Conversation

jozefizso
Copy link

I replaced all the deprecated functions in tap tests. This keeps the tests output nice and tidy and it allows to upgrade to the latest tap release (v20 for NodeJS 18+, or v21 for NodeJS 20+) in the future.

Test report on master branch:

Suites:   ​33 passed​, ​33 of 33 completed
Asserts:  ​​​6187 passed​, ​of 6187
​Time:​   ​3s

Test report after replacing deprecated functions:

Suites:   ​33 passed​, ​33 of 33 completed
Asserts:  ​​​6187 passed​, ​of 6187
​Time:​   ​2s

@jozefizso jozefizso mentioned this pull request Oct 13, 2024
Merged
@jozefizso jozefizso marked this pull request as draft October 13, 2024 12:24
@jozefizso jozefizso marked this pull request as ready for review October 13, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jozefizso