Skip to content

[QA-466] Accept non-virtual builder name in builders filter #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[QA-466] Accept non-virtual builder name in builders filter #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion master/buildbot/reporters/generators/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ def is_message_needed_by_props(self, build):
builder = build['builder']
scheduler = build['properties'].get('scheduler', [None])[0]
branch = build['properties'].get('branch', [None])[0]
buildername = build['properties'].get('buildername', [None])[0]

if self.builders is not None and builder['name'] not in self.builders:
if self.builders is not None and not (builder['name'] in self.builders or buildername in self.builders):
return False
if self.schedulers is not None and scheduler not in self.schedulers:
return False
Expand Down