[QA-466] Accept non-virtual builder name in builders filter #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Change the filtering in
is_message_needed_by_props
to accept the non-virtual builder name for a build.🤔 Motivation
The Virtual Builders pattern allows us to schedule multiple builds of the same source and builder with different properties. We use this to split the testing and packaging work over many workers.
The issue is that we would like to define a GitHubStatusPush reporter for each of these builders, however, as the
virtual_builder_name
of the builder is calculated at build time, we can't enumerate them during configuration.💇 Testing
To test I've configured the following reporters in the
master.cfg
:Which publishes messages like:
Without this change the messages were only emitted if I set