Skip to content

Use logging instead of traceback #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roach merged 1 commit into from
Apr 3, 2018
+4 −2
Merged

Use logging instead of traceback #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions slackclient/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
# mostly a proxy object to abstract how some of this works

import json
import traceback
import logging

from .server import Server
from .exceptions import ParseResponseError

LOG = logging.getLogger(__name__)


class SlackClient(object):
'''
Expand Down Expand Up @@ -52,7 +54,7 @@ def rtm_connect(self, with_team_state=True, **kwargs):
self.server.rtm_connect(use_rtm_start=with_team_state, **kwargs)
return self.server.connected
except Exception:
traceback.print_exc()
LOG.warn("Failed RTM connect", exc_info=True)
return False

def api_call(self, method, timeout=None, **kwargs):
Expand Down