Use logging instead of traceback #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just outputting to stderr the rtm connect failure it is more appropriate to use the python logging system and output a appropriate message (and pass in exc_info=True so that the traceback gets logged as well).
Roach
approved these changes
Apr 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
=========================================
+ Coverage 74.33% 74.4% +0.06%
=========================================
Files 10 10
Lines 378 379 +1
Branches 67 67
=========================================
+ Hits 281 282 +1
Misses 88 88
Partials 9 9
Continue to review full report at Codecov.
|
lavabyrd
pushed a commit
that referenced
this pull request
Apr 25, 2019
Instead of just outputting to stderr the rtm connect failure it is more appropriate to use the python logging system and output a appropriate message (and pass in exc_info=True so that the traceback gets logged as well).
2 tasks
c-goosen
pushed a commit
to c-goosen/python-slackclient
that referenced
this pull request
Jun 18, 2019
Instead of just outputting to stderr the rtm connect failure it is more appropriate to use the python logging system and output a appropriate message (and pass in exc_info=True so that the traceback gets logged as well).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just outputting to stderr the rtm connect
failure it is more appropriate to use the python logging
system and output a appropriate message (and pass in
exc_info=True so that the traceback gets logged as well).
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an
xin each[ ])