fix: remove environment variable management#27
Merged
WilliamBergamin merged 2 commits intomainfrom Feb 23, 2024
Merged
Conversation
Environment variable management is now handled by the CLI it does not need to be handled by the hooks as well
WilliamBergamin
added
enhancement
zimeg
approved these changes
Feb 22, 2024
Member
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM and works great! Always exciting to see lines removed 🪓
Comment on lines
-20
to
-24
| def validate_env() -> None: | ||
| if not os.environ.get(SLACK_CLI_XOXB): | ||
| raise CliError(f"Missing local run bot token ({SLACK_CLI_XOXB}).") | ||
| if not os.environ.get(SLACK_CLI_XAPP): | ||
| raise CliError(f"Missing local run app token ({SLACK_CLI_XAPP}).") |
Member
There was a problem hiding this comment.
No harm in removing this IMO since an error will eventually be caught in the app if these variables are expected! I imagine this guard was to ensure hooks are called from the CLI but I'm honestly not sure 🤔
Contributor
Author
There was a problem hiding this comment.
If I remember correctly this was additional safeguard that was originally put in but we don't need it anymore
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment variable management of
SLACK_BOT_TOKENandSLACK_APP_TOKENis now handled by the CLI these changes remove the duplicate implementation from the hooksTesting
slack create tests-automation -t https://github.com/slack-samples/bolt-python-custom-function-templatescripts/build_pypi_package.shslack create tests-automation -t https://github.com/slack-samples/bolt-python-custom-function-templatecd tests-automationrequirements.txtreplaceslack-cli-hookswithpath/to/python-slack-hooks/dist/slack_cli_hooks-0.0.0.dev2-py3-none-any.whlpython -m venv .venv && source .venv/bin/activate && pip install -r requirements.txtslack runEverything should work 👍
Special notes
N/A
Requirements
./scripts/install_and_run_tests.shafter making the changes.