cli-hooks(fix): remove environment variable requirements from the start hook#1835
Merged
zimeg merged 1 commit intoslackapi:mainfrom Jun 28, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
- Coverage 81.85% 81.81% -0.05%
==========================================
Files 35 35
Lines 7783 7764 -19
Branches 318 318
==========================================
- Hits 6371 6352 -19
Misses 1400 1400
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
srajiang
approved these changes
Jun 28, 2024
Member
Author
|
@srajiang thank you for the fast review! I'll merge this now but hold off on a release for a bit more testing on errors and exits 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes validation of environment variables from the
starthook since it's not always true that these tokens are required to run an app. For instance, an app token isn't needed when running using HTTP Request URLs!Similar assertions were removed and don't exist in
slackapi/python-slack-hooks: slackapi/python-slack-hooks#27Requirements