Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Retry-After raw response header value when throwing an error due to invalid Retry-After header #1426

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Include Retry-After raw response header value when throwing an error due to invalid Retry-After header #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web-api/src/WebClient.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,6 +1143,7 @@ describe('WebClient', function () {
client.apiCall('method')
.catch((err) => {
assert.instanceOf(err, Error);
assert.include(err.message, 'retry-after header: notanumber', 'Raw retry-after header value included in error');
scope.done();
done();
});
Expand Down
2 changes: 1 addition & 1 deletion packages/web-api/src/WebClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ export class WebClient extends Methods {
throw Error(`A rate limit was exceeded (url: ${url}, retry-after: ${retrySec})`);
} else {
// TODO: turn this into some CodedError
throw new AbortError(new Error(`Retry header did not contain a valid timeout (url: ${url})`));
throw new AbortError(new Error(`Retry header did not contain a valid timeout (url: ${url}, retry-after header: ${response.headers['retry-after']})`));
}
}

Expand Down