Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Retry-After raw response header value when throwing an error due to invalid Retry-After header #1426

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Feb 15, 2022

Summary

This is an incremental improvement for #1421. When we raise an exception due to a seemingly invalid or unparseable Retry-After header value, we include the raw header value in the error thrown to help track down / narrow in a potential cause for #1421.

…eader value when throwing an error due to unparseable/invalid header value
@filmaj filmaj added semver:patch enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` labels Feb 15, 2022
@filmaj filmaj added this to the web-api@6.7.0 milestone Feb 15, 2022
@filmaj filmaj self-assigned this Feb 15, 2022
Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement

@seratch seratch merged commit 00a2ddd into main Feb 15, 2022
@seratch seratch deleted the log-retry-header-if-corrupt branch February 15, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants