Fix authorization on methods which uses get requests#921
Merged
Conversation
|
Hey! I've also confirmed that this branch fixes the authentication issues I was seeing using the new Slack App authentication flow and file uploads. Any thing we can do to help get this merged? |
Member
|
Sorry for delay. I'll confirm later 🙇 |
Member
|
note: #857 |
Member
|
Released in v0.8.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Not sure how long these methods don't work, according to the Slack API docs passing tokens as get parameters isn't allowed
https://api.slack.com/web#slack-web-api__authentication
When I migrated my application to the new Slack application I started getting auth errors on chat.getPermalink method. Looks like they force this rule in new apps.