Skip to content

Seems the token was missing from the request.#908

Merged
kanata2 merged 2 commits into
slack-go:masterfrom
aubelsb2:tokenismissing
Apr 17, 2021
Merged

Seems the token was missing from the request.#908
kanata2 merged 2 commits into
slack-go:masterfrom
aubelsb2:tokenismissing

Conversation

@aubelsb2
Copy link
Copy Markdown
Contributor

As far as I can tell it's because of a token is missing.

@aubelsb2
Copy link
Copy Markdown
Contributor Author

Probably handled in the http client.

@aubelsb2 aubelsb2 reopened this Mar 10, 2021
@aubelsb2
Copy link
Copy Markdown
Contributor Author

aubelsb2 commented Mar 10, 2021

Verified to fix my issue. Seems they are checking for unnecessary parameters or at least token being in the wrong location.

@kanata2
Copy link
Copy Markdown
Member

kanata2 commented Mar 16, 2021

@aubelsb2

I commented related issue. #903 (comment)
Could you fix other codes where same problems occur too?(if exists)
If it is difficult, please let me know so I can find the time to do it.

@kanata2 kanata2 added bugfix [PR] bugfix spec changes Slack's specification changes labels Mar 16, 2021
@bailantaotao
Copy link
Copy Markdown

Is there any update for this?

@aubelsb2
Copy link
Copy Markdown
Contributor Author

When I get a weekend spare I can work on it.

@raylas
Copy link
Copy Markdown

raylas commented Apr 6, 2021

Would also love to see this merged ☝🏼

@joshm91
Copy link
Copy Markdown

joshm91 commented Apr 10, 2021

Looks like #921 fixes this issue properly. This library is pretty much broken to any newcomers at the moment so it'd be great to get the fix merged ASAP. Thanks!

@kanata2 kanata2 merged commit e0d14cc into slack-go:master Apr 17, 2021
@kanata2
Copy link
Copy Markdown
Member

kanata2 commented Apr 17, 2021

Relased in v0.8.3

@arran4
Copy link
Copy Markdown

arran4 commented Apr 20, 2021

Following up from personal account. Does effort still need to be done by me? I feel like the change to remove query param token from the library will require significant change.

@kanata2
Copy link
Copy Markdown
Member

kanata2 commented Apr 20, 2021

In my recognition, #857 was resolved in v0.8.3.

However it may be better to use application/json as Slack's recommendation(the followings).

Some methods, like chat.postMessage and dialog.open feature arguments that accept an associative JSON array. These methods can be difficult to properly construct when using a application/x-www-form-urlencoded Content-type, and we strongly recommend using JSON-encoded bodies instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix [PR] bugfix spec changes Slack's specification changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants