WINTER ingestion into kowalski #174
Conversation
Winterstream
Update winter tests & fix linting
|
@guynir42 @mcoughlin I think the PR is ready for review, thanks! |
| @@ -0,0 +1,404 @@ | |||
| from confluent_kafka import Producer | |||
There was a problem hiding this comment.
Can we add some info to the README or similar about what is different about this ingester than for ZTF? I.e. it's all the same but XYZ?
There was a problem hiding this comment.
Added a summary of the changes to README. here
| @@ -0,0 +1,627 @@ | |||
| from abc import ABC | |||
There was a problem hiding this comment.
I think some summary of what is different than ZTF here would be very useful for future additions.
There was a problem hiding this comment.
Updated README with the details - here
kowalski/alert_broker.py
Outdated
| # fixme: PGIR uses 2massj, which is not in sncosmo as of 20210803 | ||
| # cspjs seems to be close/good enough as an approximation | ||
| # 20220818: added WNTR |
There was a problem hiding this comment.
I added more bandpasses since then:
https://sncosmo.readthedocs.io/en/stable/bandpass-list.html
There was a problem hiding this comment.
Added bandpasses, also fixed a small bug so that the filter is not hardcoded for WINTER and any of the WINTER filters can be processed.
| phot_bp_mean_mag: 1 | ||
| phot_rp_mean_mag: 1 | ||
|
|
||
| Gaia_EDR3: |
There was a problem hiding this comment.
Do you need DR2 and eDR3?
There was a problem hiding this comment.
Got rid of DR2, we probably want to keep EDR3. Also reduced the xmatch radius to 2 arcsec
Winterstream
|
@virajkaram Looks like you need to remove version.txt from your commit (thanks for the .gitignore), otherwise should be good to go in. |
Done! |
This PR implements the ingestion of the WINTER alert stream into Kowalski.
kowalski/check_db_entries.pyfor easier debugging.