[Spot/UX]: Spot dashboard Added delay for ssh_command to initialize #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Jun 27, 2023
sky/cli.py
Outdated
| @@ -3736,6 +3737,7 @@ def spot_dashboard(port: Optional[int]): | |||
|
|
|||
| with subprocess.Popen(ssh_command, shell=True, | |||
| start_new_session=True) as ssh_process: | |||
| time.sleep(5) # Added delay for ssh_command to initialize. | |||
There was a problem hiding this comment.
Does 2s or 1s work? 5s feels a bit long.
There was a problem hiding this comment.
Reduced to 3s.
It takes around 2+s on my computer.
Or maybe we can simply remove webbrowser.open and let user click the link in the prompt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2123
User feedback
Added a delay between ssh command and webbrowser.open.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh