Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spot dashboard/UI] Page failed to display in the first few seconds after opening #2123

Closed
concretevitamin opened this issue Jun 22, 2023 · 2 comments · Fixed by #2136
Closed

[spot dashboard/UI] Page failed to display in the first few seconds after opening #2123

concretevitamin opened this issue Jun 22, 2023 · 2 comments · Fixed by #2136
Labels
friction-log good first issue Good for newcomers help wanted Extra attention is needed

Comments

@concretevitamin
Copy link
Member

User feedback

Small UX feedback: when I run sky spot dashboard, very often the page that opens first shows some error, and after a few seconds it automatically refreshes and loads. Slightly confusing user experience.

I noticed that too and not sure what's wrong.
@concretevitamin concretevitamin added help wanted Extra attention is needed good first issue Good for newcomers friction-log labels Jun 22, 2023
@MaoZiming
Copy link
Collaborator

This seems to be an issue of ssh_command needing some time to launch before the site is ready for webbrowser.open
A naive solution might be to add a time.sleep() in between.

@concretevitamin
Copy link
Member Author

@MaoZiming makes sense. Do you have time to put in a quick fix? Thanks.

@MaoZiming MaoZiming linked a pull request Jun 27, 2023 that will close this issue
[Spot/UX]: Spot dashboard Added delay for ssh_command to initialize #2136
Merged
5 tasks
@MaoZiming MaoZiming mentioned this issue Jun 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
friction-log good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Spot/UX]: Spot dashboard Added delay for ssh_command to initialize skypilot-org/skypilot
2 participants
@concretevitamin @MaoZiming