Update to new players from Brazil#170
Conversation
By biel.
✅ Deploy Preview for sklauncher-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @zitobon9-rgb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Este pull request tem como objetivo principal traduzir a documentação introdutória do SKlauncher para o português. Ao fazer isso, o projeto busca alcançar um público mais amplo e fornecer informações essenciais sobre o launcher em um idioma nativo para muitos usuários, melhorando a acessibilidade e a experiência do usuário. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request translates the introduction page into Brazilian Portuguese. While the initiative is great, the current translation has several grammatical errors, typos, and awkward phrasing that don't accurately reflect the original English text. I've left specific suggestions to improve the quality and readability of the translation. Please review the suggestions to ensure the documentation is clear and professional for Brazilian Portuguese speakers.
| ## What is SKlauncher? | ||
| SKlauncher is a game launcher for **Minecraft: Java Edition**, designed to offer players an easy-to-use, visually appealing interface for managing the game and installed modifications, along with a range of offline features. | ||
| ## Oque é o sklauncher? | ||
| Sklauncher e um launcher para o **Minecraft: Java Edition**, Feito para oferecer jogadores uma interface facil e simples de usar, Visualmente para utilizar o jogo e modificaçoes instaladas, tambem com uma parte de objetos offline. |
There was a problem hiding this comment.
This sentence has several grammatical errors and awkward translations. For example, Sklauncher e should be O SKlauncher é, and Visualmente para utilizar o jogo is not a good translation for visually appealing interface for managing the game. The suggested change below provides a more natural and accurate translation.
O SKlauncher é um launcher para o **Minecraft: Java Edition**, projetado para oferecer aos jogadores uma interface fácil de usar e visualmente atraente para gerenciar o jogo e as modificações instaladas, além de uma variedade de recursos offline.
| Sklauncher e um launcher para o **Minecraft: Java Edition**, Feito para oferecer jogadores uma interface facil e simples de usar, Visualmente para utilizar o jogo e modificaçoes instaladas, tambem com uma parte de objetos offline. | ||
|
|
||
| For {new Date().getFullYear() - 2013} years, SKlauncher has enabled users to log in with their Mojang accounts (prior to the migration to Microsoft in 2023) or use Offline accounts, with the option to create an SKlauncher account. | ||
| For {new Date().getFullYear() - 2013} anos, Sklauncher deixa jogadores lojarem com suas contas mojang (de acordo com a migraçao da microsoft em 2023) Ou use contas offline, com a opçao de criar uma conta Sklauncher. |
There was a problem hiding this comment.
This sentence contains several translation and grammatical errors.
For...anosshould beHá...anos.lojaremis not a valid Portuguese word; it should befaçam loginorlogarem.de acordo com a migraçaois an incorrect translation ofprior to the migration; it should beantes da migração.- There are also missing accents.
The suggestion below corrects these issues for a more accurate translation.
Há {new Date().getFullYear() - 2013} anos, o SKlauncher permite que os jogadores façam login com suas contas Mojang (antes da migração para a Microsoft em 2023) ou usem contas offline, com a opção de criar uma conta SKlauncher.
|
|
||
| ## The team | ||
| Since its inception, SKlauncher has been developed solely by **SKmedix**, who has served as the *primary developer*. In early 2023, **Foxer** joined the team as a *Front-End developer*. | ||
| Desde ja, Sklaucher foi feito Por **SKmedix**, que serviu como *desenvolvedor primario*. No começo de 2023, **Foxer** entrou no time como *Desenvolvedor da linha de frente*. |
There was a problem hiding this comment.
This sentence has several translation and grammatical issues. Desde ja is incorrect, Sklaucher is a typo, the word solely (apenas) was missed, and Desenvolvedor da linha de frente is a very literal and awkward translation of Front-End developer. The suggestion below provides a more natural and accurate translation.
Desde o seu início, o SKlauncher foi desenvolvido apenas por **SKmedix**, que atuou como *desenvolvedor principal*. No início de 2023, **Foxer** juntou-se à equipe como *desenvolvedor Front-End*.
| Desde ja, Sklaucher foi feito Por **SKmedix**, que serviu como *desenvolvedor primario*. No começo de 2023, **Foxer** entrou no time como *Desenvolvedor da linha de frente*. | ||
|
|
||
| Although the team is small, **the community** plays an invaluable role: users contribute by *translating the launcher*, *testing* and reporting bugs, *moderating* the Discord server, and providing *support* to fellow users. | ||
| Mesmo que o time swja pequeno, **A comunidade** Joga de uma forma inviavel : alguns ajudam a *traduzir o launcher*, *testar* reportando bugs, *moderando* O servidor do discord, E provendo suporte para novos usuarios. |
There was a problem hiding this comment.
This sentence has significant translation issues. swja is a typo for seja. The phrase Joga de uma forma inviavel is a mistranslation of plays an invaluable role and doesn't make sense in Portuguese (inviavel means unviable). The suggestion below provides a much clearer and more accurate translation of the original text.
Embora a equipe seja pequena, **a comunidade** desempenha um papel inestimável: os usuários contribuem *traduzindo o launcher*, *testando* e reportando bugs, *moderando* o servidor do Discord e fornecendo *suporte* a outros usuários.
| title: Introduçao | ||
| description: documento oficial do SkLauncher, um launcher de jogo para Minecraft - Java Edition |
There was a problem hiding this comment.
There are a few corrections needed in the title and description for proper Portuguese grammar and capitalization.
Introduçaoshould beIntrodução.documentoshould be capitalized:Documentação.SkLaunchershould beSKlauncherto be consistent with the project's branding.- It's more natural to say
para o Minecraftinstead ofpara Minecraft.
title: Introdução
description: Documentação oficial do SKlauncher, um launcher de jogo para o Minecraft: Java Edition
| </li> | ||
| <li> | ||
| <span>🔒</span> Supports authentication with Microsoft accounts | ||
| <span>🔒</span> Suporta autenticaçao com contas microsoft |
| </li> | ||
| <li> | ||
| <span>🚀</span> Frequently updated to provide new features | ||
| <span>🚀</span> atualizado frequentemente para proveder novas coisas |
| </li> | ||
| <li> | ||
| <span>📦</span> Supports installing and managing modifications \* | ||
| <span>📦</span> Suporta a instalaçao e manejamento de modificaçoes \* |
There was a problem hiding this comment.
There are a few spelling and word choice issues here:
instalaçaoshould beinstalação.manejamentois not the best word formanaging;gerenciamentois more appropriate.modificaçoesshould bemodificações.
Also, please remove the extra space before the asterisk.
<span>📦</span> Suporta a instalação e gerenciamento de modificações \*
| </li> | ||
| <li> | ||
| <span>💄</span> Simple and easy-to-use design | ||
| <span>💄</span> Design simples e facil e usar |
| </ul> | ||
|
|
||
| <small>\* - This feature is currently in development</small> | ||
| <small>\* - essa featura ainda esta em desenvolvimento</small> |
There was a problem hiding this comment.
This sentence has a few errors:
featurais not a Portuguese word. The correct term forfeatureisrecursoorfuncionalidade.estais missing an accent and should beestá.essashould beEsteto agree withrecurso(masculine noun).
A better translation is suggested below.
<small>\* - Este recurso está atualmente em desenvolvimento</small>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughDocumentation file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
By biel.
Summary by CodeRabbit