Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Complete #3140 #3151

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[python] Complete #3140 #3151

merged 2 commits into from
Oct 9, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 9, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

On #3140 I missed a spot. I found this while working on experiment-level resize on #3148.

Notes for Reviewer:

@johnkerl johnkerl requested a review from nguyenv October 9, 2024 00:23
@johnkerl johnkerl marked this pull request as ready for review October 9, 2024 00:24
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.04%. Comparing base (50d63c1) to head (71929ba).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
+ Coverage   82.92%   83.04%   +0.11%     
==========================================
  Files          50       50              
  Lines        5229     5236       +7     
==========================================
+ Hits         4336     4348      +12     
+ Misses        893      888       -5     
Flag Coverage Δ
python 83.04% <77.77%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.04% <77.77%> (+0.11%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl requested a review from jp-dark October 9, 2024 13:42
@johnkerl johnkerl merged commit 46bf2ec into main Oct 9, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/py-can-upgrade-shape branch October 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants