Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Connect resizers to the Python API #3140

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 6, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

Connects the resizers to the Python API, for #2964

Notes for Reviewer:

R support on a separate PR. Less urgent since R doesn't have append mode yet (#1630).

@johnkerl johnkerl changed the base branch from main to kerl/cpp-dataframe-upgrade-test October 6, 2024 15:32
@johnkerl johnkerl changed the title [python] Connect resizers to Python API [python] Connect resizers to the Python API Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (6b65790) to head (d121dc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
- Coverage   83.05%   83.03%   -0.02%     
==========================================
  Files          50       50              
  Lines        5198     5229      +31     
==========================================
+ Hits         4317     4342      +25     
- Misses        881      887       +6     
Flag Coverage Δ
python 83.03% <68.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.03% <68.42%> (-0.02%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review October 6, 2024 23:20
@johnkerl johnkerl requested a review from nguyenv October 8, 2024 17:15
Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Base automatically changed from kerl/cpp-dataframe-upgrade-test to main October 8, 2024 17:25
@johnkerl johnkerl merged commit 50d63c1 into main Oct 8, 2024
21 checks passed
@johnkerl johnkerl deleted the kerl/py-resizer-connects branch October 8, 2024 18:20
@johnkerl johnkerl mentioned this pull request Oct 9, 2024
johnkerl added a commit that referenced this pull request Oct 9, 2024
* [python] Complete 3140

* add unit-test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants