-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] Push attrnames
down to C++
#3121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3121 +/- ##
==========================================
+ Coverage 86.56% 86.61% +0.05%
==========================================
Files 47 47
Lines 4920 4924 +4
==========================================
+ Hits 4259 4265 +6
+ Misses 661 659 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; please remember to bump the develop version, update the changelog, and 🚢
@mojaveazure my apologies -- I mixed up this PR and #3079 and did the |
I'm not seeing an attrnames-pushdown in the changelog on 3079 https://github.com/single-cell-data/TileDB-SOMA/pull/3079/files#diff-e11a770652d5ae632a176b47454e64a9ab4168f1337594fa0022502100c0563e; can you add it as part of that PR so that we can have it in the changelog? |
#2406
#3058
[sc-55674]