Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Push attrnames down to C++ #3121

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[r] Push attrnames down to C++ #3121

merged 2 commits into from
Oct 3, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (0a9bf28) to head (7c70bbc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
+ Coverage   86.56%   86.61%   +0.05%     
==========================================
  Files          47       47              
  Lines        4920     4924       +4     
==========================================
+ Hits         4259     4265       +6     
+ Misses        661      659       -2     
Flag Coverage Δ
python 86.61% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.61% <ø> (+0.05%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; please remember to bump the develop version, update the changelog, and 🚢

@johnkerl johnkerl merged commit 342673e into main Oct 3, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/cpp-attrnames-pushdown branch October 3, 2024 19:29
@johnkerl
Copy link
Member Author

johnkerl commented Oct 3, 2024

@mojaveazure my apologies -- I mixed up this PR and #3079 and did the DESCRIPITON / NEWS.md mods here:
https://github.com/single-cell-data/TileDB-SOMA/pull/3079/commits

johnkerl added a commit that referenced this pull request Oct 3, 2024
@mojaveazure
Copy link
Member

I'm not seeing an attrnames-pushdown in the changelog on 3079 https://github.com/single-cell-data/TileDB-SOMA/pull/3079/files#diff-e11a770652d5ae632a176b47454e64a9ab4168f1337594fa0022502100c0563e; can you add it as part of that PR so that we can have it in the changelog?

@johnkerl
Copy link
Member Author

johnkerl commented Oct 3, 2024

#3122

johnkerl added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants