Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Update comments, remove unused test params #2873

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Aug 9, 2024

Issue and/or context: #2829, #2804, #2868

Changes:

  • Tests introduced in [python] Ingest/outgest round-trip improvements #2804 included configurable outgest_default_index_name and outgest_fallback_index_name fields, that were never set to non-default values. Removing them here, to avoid confusion.
  • Other comment updates / typo fixes

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (190e479) to head (2e5b53a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
+ Coverage   89.69%   89.84%   +0.15%     
==========================================
  Files          37       37              
  Lines        3940     3940              
==========================================
+ Hits         3534     3540       +6     
+ Misses        406      400       -6     
Flag Coverage Δ
python 89.84% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.84% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams marked this pull request as ready for review August 12, 2024 13:24
@johnkerl johnkerl changed the title [python] update comments, remove unused test params [python] Update comments, remove unused test params Aug 12, 2024
apis/python/src/tiledbsoma/io/ingest.py Show resolved Hide resolved
apis/python/tests/_util.py Show resolved Hide resolved
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ryan-williams ryan-williams merged commit 46fdeee into main Aug 13, 2024
21 checks passed
@ryan-williams ryan-williams deleted the rw/nits branch August 13, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants