[python] Utilize Arrow schema pa.field nullabilities in DataFrame.create
#2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
pa.field nullabilitiespython Respect Arrow schema pa.field nullabilities in DataFrame.create
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
- Coverage 90.04% 89.77% -0.27%
==========================================
Files 37 37
Lines 3957 3961 +4
==========================================
- Hits 3563 3556 -7
- Misses 394 405 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Aug 9, 2024
johnkerl
changed the title
python Respect Arrow schema pa.field nullabilities in DataFrame.createpython Utilize Arrow schema pa.field nullabilities in DataFrame.create
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
…create` (#2868) * Respect Arrow schema `pa.field` nullabilities * Move most of the impl comments to issue 2869, now that I created it
ryan-williams
added a commit
that referenced
this pull request
Aug 9, 2024
ryan-williams
added a commit
that referenced
this pull request
Aug 9, 2024
ryan-williams
added a commit
that referenced
this pull request
Aug 9, 2024
ryan-williams
added a commit
that referenced
this pull request
Aug 12, 2024
ryan-williams
added a commit
that referenced
this pull request
Aug 13, 2024
ryan-williams
added a commit
that referenced
this pull request
Aug 13, 2024
* fix comment typos from #2868 * fix docstring typos * update `ingest._write_dataframe` docstring * `test_dataframe_io_roundtrips.py`: rm unused test params * `test_dataframe_io_roundtrips.py`: add docs/comments * add `parametrize_cases` helper factored out of `test_dataframe_io_roundtrips.py` * mv `make_df` to `tests._util` * `parametrize_cases`: use `id` field instead of `name`
johnkerl
changed the title
python Utilize Arrow schema pa.field nullabilities in DataFrame.createpa.field nullabilities in DataFrame.create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #2869