Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] More reshape neatens #2828

Merged
merged 1 commit into from
Aug 2, 2024
Merged

[python] More reshape neatens #2828

merged 1 commit into from
Aug 2, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 2, 2024

Issue and/or context: Continuation of #2826. I somehow missed some unit-test signal.

Changes:

Notes for Reviewer:

@johnkerl johnkerl changed the title [python] More reshape GC [python] More reshape neatens Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (d6e0719) to head (8c6bccf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.01%     
==========================================
  Files          37       37              
  Lines        3939     3937       -2     
==========================================
- Hits         3548     3546       -2     
  Misses        391      391              
Flag Coverage Δ
python 90.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.06% <ø> (-0.01%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

johnkerl commented Aug 2, 2024

CI fail is separately tracked on #2827

@johnkerl johnkerl merged commit 1fd58d1 into main Aug 2, 2024
10 of 11 checks passed
@johnkerl johnkerl deleted the kerl/even-less-reshape branch August 2, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants