Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] pin codecov/uploader==0.7.3 in codecov-action #2827

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Aug 2, 2024

Issue and/or context: work-around for codecov/uploader#1673

uploader@0.8.0 was released 4h ago, and broke our invocations of codecov-action@v3 (example job that passed yesterday, and failed on re-run today)

Failures look like:

==> macos OS detected
https://uploader.codecov.io/latest/macos/codecov.SHA256SUM
==> SHASUM file signed by key id 806bb28aed779869
==> Uploader SHASUM verified (75086ee436f6f74c4e8f65448eaa399e38bc93bb27a53d057b24b275b9f78c89  codecov)
==> Running version latest
==> Running version v0.8.0
/Users/runner/work/_actions/codecov/codecov-action/v3/dist/codecov -n  -Q github-action-3.1.6 -F python -C 25949be8d2ce35ef5beafd55bb1fd83c96e894b0
Error: spawn Unknown system error -86
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at Object.spawn (node:child_process:761:9)
    at ToolRunner.<anonymous> (/Users/runner/work/_actions/codecov/codecov-action/v3/webpack:/codecov-action/node_modules/@actions/exec/lib/toolrunner.js:4[13](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10201203260/job/28277665063#step:14:14):1)
    at Generator.next (<anonymous>)
    at /Users/runner/work/_actions/codecov/codecov-action/v3/webpack:/codecov-action/node_modules/@actions/exec/lib/toolrunner.js:27:1
    at new Promise (<anonymous>)
    at __webpack_modules__.8[15](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/10201203260/job/28277665063#step:14:16)9.__awaiter (/Users/runner/work/_actions/codecov/codecov-action/v3/webpack:/codecov-action/node_modules/@actions/exec/lib/toolrunner.js:23:1)
    at /Users/runner/work/_actions/codecov/codecov-action/v3/webpack:/codecov-action/node_modules/@actions/exec/lib/toolrunner.js:395:1
    at new Promise (<anonymous>)
    at ToolRunner.<anonymous> (/Users/runner/work/_actions/codecov/codecov-action/v3/webpack:/codecov-action/node_modules/@actions/exec/lib/toolrunner.js:395:1)

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (1fd58d1) to head (1c2eef9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2827   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          37       37           
  Lines        3937     3937           
=======================================
  Hits         3546     3546           
  Misses        391      391           
Flag Coverage Δ
python 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.06% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams marked this pull request as ready for review August 2, 2024 21:39
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ryan-williams ryan-williams merged commit c931ffe into main Aug 2, 2024
12 checks passed
@ryan-williams ryan-williams deleted the rw/cov branch August 2, 2024 21:40
ryan-williams added a commit that referenced this pull request Aug 8, 2024
rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)
ryan-williams added a commit that referenced this pull request Aug 8, 2024
* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854
mojaveazure added a commit that referenced this pull request Aug 9, 2024
* [python] pin `pandas-stubs>=2` during pre-commit `mypy` hook (#2854)

* pin `pandas-stubs>=2` during pre-commit `mypy` hook

also simplify some `if TYPE_CHECKING` blocks

fixes #2839

* add r-ci.yml exclusions

* `actions{cache,checkout,setup-python}` upgrades (#2856)

* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854

* [python] Offer better guidance on attribute names with `.` (#2864)

* [python] Move `_update_column` into pybind11 (#2862)

* [r] Expose `tiledb_timestamp` parameter to `$reopen()`
Allow `$reopen()` to reopen at a particular timestamp; by default, the
timestamp is set to `NULL` to reopen at the curren time. This is needed
for compatibility between libtiledbsoma's timestamp handling and
resume-mode

[SC-52694](https://app.shortcut.com/tiledb-inc/story/52694/allow-reopen-to-take-a-timestamp-for-reopening)

---------

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
eddelbuettel pushed a commit that referenced this pull request Aug 9, 2024
* [python] pin `pandas-stubs>=2` during pre-commit `mypy` hook (#2854)

* pin `pandas-stubs>=2` during pre-commit `mypy` hook

also simplify some `if TYPE_CHECKING` blocks

fixes #2839

* add r-ci.yml exclusions

* `actions{cache,checkout,setup-python}` upgrades (#2856)

* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854

* [python] Offer better guidance on attribute names with `.` (#2864)

* [python] Move `_update_column` into pybind11 (#2862)

* [r] Expose `tiledb_timestamp` parameter to `$reopen()`
Allow `$reopen()` to reopen at a particular timestamp; by default, the
timestamp is set to `NULL` to reopen at the curren time. This is needed
for compatibility between libtiledbsoma's timestamp handling and
resume-mode

[SC-52694](https://app.shortcut.com/tiledb-inc/story/52694/allow-reopen-to-take-a-timestamp-for-reopening)

---------

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
eddelbuettel pushed a commit that referenced this pull request Aug 19, 2024
* [python] pin `pandas-stubs>=2` during pre-commit `mypy` hook (#2854)

* pin `pandas-stubs>=2` during pre-commit `mypy` hook

also simplify some `if TYPE_CHECKING` blocks

fixes #2839

* add r-ci.yml exclusions

* `actions{cache,checkout,setup-python}` upgrades (#2856)

* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854

* [python] Offer better guidance on attribute names with `.` (#2864)

* [python] Move `_update_column` into pybind11 (#2862)

* [r] Expose `tiledb_timestamp` parameter to `$reopen()`
Allow `$reopen()` to reopen at a particular timestamp; by default, the
timestamp is set to `NULL` to reopen at the curren time. This is needed
for compatibility between libtiledbsoma's timestamp handling and
resume-mode

[SC-52694](https://app.shortcut.com/tiledb-inc/story/52694/allow-reopen-to-take-a-timestamp-for-reopening)

---------

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
eddelbuettel pushed a commit that referenced this pull request Aug 22, 2024
* [python] pin `pandas-stubs>=2` during pre-commit `mypy` hook (#2854)

* pin `pandas-stubs>=2` during pre-commit `mypy` hook

also simplify some `if TYPE_CHECKING` blocks

fixes #2839

* add r-ci.yml exclusions

* `actions{cache,checkout,setup-python}` upgrades (#2856)

* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854

* [python] Offer better guidance on attribute names with `.` (#2864)

* [python] Move `_update_column` into pybind11 (#2862)

* [r] Expose `tiledb_timestamp` parameter to `$reopen()`
Allow `$reopen()` to reopen at a particular timestamp; by default, the
timestamp is set to `NULL` to reopen at the curren time. This is needed
for compatibility between libtiledbsoma's timestamp handling and
resume-mode

[SC-52694](https://app.shortcut.com/tiledb-inc/story/52694/allow-reopen-to-take-a-timestamp-for-reopening)

---------

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
mojaveazure added a commit that referenced this pull request Aug 26, 2024
* Timestamp range support for dataframe

* Extended support

* (First half) new timestamp test for SOMADataFrame

* Second half of new timestamp passing all but three reopen tests

* [r] Expose `tiledb_timestamp` parameter to `$reopen()` (#2866)

* [python] pin `pandas-stubs>=2` during pre-commit `mypy` hook (#2854)

* pin `pandas-stubs>=2` during pre-commit `mypy` hook

also simplify some `if TYPE_CHECKING` blocks

fixes #2839

* add r-ci.yml exclusions

* `actions{cache,checkout,setup-python}` upgrades (#2856)

* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854

* [python] Offer better guidance on attribute names with `.` (#2864)

* [python] Move `_update_column` into pybind11 (#2862)

* [r] Expose `tiledb_timestamp` parameter to `$reopen()`
Allow `$reopen()` to reopen at a particular timestamp; by default, the
timestamp is set to `NULL` to reopen at the curren time. This is needed
for compatibility between libtiledbsoma's timestamp handling and
resume-mode

[SC-52694](https://app.shortcut.com/tiledb-inc/story/52694/allow-reopen-to-take-a-timestamp-for-reopening)

---------

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>

* [r] [NO BACKPORT] Expose timestamps publicly and plumb through for resume-mode (#2871)

Expose timestamps publicly through a new active binding; replace calls to `private$tiledb_timestamp` with `self$tiledb_timestamp`

Also plumb timestamps through for `write_soma()` in resume-mode

* Timestamp range support for dataframe

* (First half) new timestamp test for SOMADataFrame

* Second half of new timestamp passing all but three reopen tests

* Test can now use factor

* Read and write DataFrame and {Dense,Sparse}Array under timestamps

* Quieter warnings

* Adapt one timestamped test

* Pause one test predicate for collections

* clang-format

as obsessing over one whitespace char before a comment is added value

* Micro-fix following code review

More changes to follow in wider changeset

* Update changelog
Bump develop version

---------

Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
Co-authored-by: Paul Hoffman <paul.hoffman@tiledb.com>
mojaveazure added a commit that referenced this pull request Aug 26, 2024
* [python] pin `pandas-stubs>=2` during pre-commit `mypy` hook (#2854)

* pin `pandas-stubs>=2` during pre-commit `mypy` hook

also simplify some `if TYPE_CHECKING` blocks

fixes #2839

* add r-ci.yml exclusions

* `actions{cache,checkout,setup-python}` upgrades (#2856)

* CI: use `pip` directly (instead of `python -m pip`)

* CI: checkout@v4, setup-python@v5 cache@v4

* disable setup-python cache for lint/pre-commit

See actions/setup-python#919; setup-python cache likely doesn't help much here, as we only `pip install pre-commit`, and cache `~/.cache/pre-commit` separately using `actions/cache`.

* bump to codecov-action@v4

rm coverage/uploader pin added in #2827, per codecov/uploader#1673 (comment)

* `s/MacOS/macOS/

* fix typo from #2854

* [python] Offer better guidance on attribute names with `.` (#2864)

* [python] Move `_update_column` into pybind11 (#2862)

* [r] Expose `tiledb_timestamp` parameter to `$reopen()`
Allow `$reopen()` to reopen at a particular timestamp; by default, the
timestamp is set to `NULL` to reopen at the curren time. This is needed
for compatibility between libtiledbsoma's timestamp handling and
resume-mode

[SC-52694](https://app.shortcut.com/tiledb-inc/story/52694/allow-reopen-to-take-a-timestamp-for-reopening)

---------

Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Co-authored-by: nguyenv <vivian@tiledb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants