Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] General CMake clean-up #2762

Merged
merged 9 commits into from
Jun 28, 2024
Merged

[c++] General CMake clean-up #2762

merged 9 commits into from
Jun 28, 2024

Commits on Jun 21, 2024

  1. Update compile options to be target based

    @jp-dark
    jp-dark committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c43e9de View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Remove COMPILE_LANGUAGE for -Wno-literal-suffix 

    We are only using the compile options on C++ libraries, so no need to
specify compile language. Using the generator expression for the
target based compile options was causing a CMake error.
    @jp-dark
    jp-dark committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a4083d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Find packages and set coverage flags once

    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5a691cd View commit details
    Browse the repository at this point in the history

  2. Split Werror away from other compile options

    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    72442fb View commit details
    Browse the repository at this point in the history

  3. Remove BUILD_COMMIT_HASH computation 

    The TileDB-SOMA library does not define a BUILD_COMMIT_HASH variable.
    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3364d2d View commit details
    Browse the repository at this point in the history

  4. Fix flag for preventing TileDB deprecation warnings

    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6cd47b0 View commit details
    Browse the repository at this point in the history

  5. Create variable for sanitizer flags

    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b21954d View commit details
    Browse the repository at this point in the history

  6. Move sanitizer INTERFACE inside main add_library block

    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1830fdd View commit details
    Browse the repository at this point in the history

  7. Move TILEDB_INSTALL_TARGETS closer to use

    @jp-dark
    jp-dark committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b47cee7 View commit details
    Browse the repository at this point in the history