[c++] General CMake clean-up #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are only using the compile options on C++ libraries, so no need to specify compile language. Using the generator expression for the target based compile options was causing a CMake error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 37 37
Lines 3939 3939
==========================================
+ Hits 3540 3546 +6
+ Misses 399 393 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jp-dark
changed the title
The TileDB-SOMA library does not define a BUILD_COMMIT_HASH variable.
eddelbuettel
approved these changes
Jun 27, 2024
eddelbuettel
approved these changes
Jun 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
* Add options explicitly to targets instead of to everything. Note: this means compile options are no longer propagated to third-party libraries included with `FetchContent` and `ExternalProject_Add`. * Move `find_package` calls and coverage flags to base `CMakeLists.txt` instead of adding them twice. * Re-arrange some CMake calls to reduce redundancy and improve readability. * Remove unused GIT_COMMIT_HASH compiler definition. * Change TileDB deprecation flag to use Core flag that is not over-written.
johnkerl
pushed a commit
that referenced
this pull request
Jul 4, 2024
* Add options explicitly to targets instead of to everything. Note: this means compile options are no longer propagated to third-party libraries included with `FetchContent` and `ExternalProject_Add`. * Move `find_package` calls and coverage flags to base `CMakeLists.txt` instead of adding them twice. * Re-arrange some CMake calls to reduce redundancy and improve readability. * Remove unused GIT_COMMIT_HASH compiler definition. * Change TileDB deprecation flag to use Core flag that is not over-written. Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Closes #2664
Changes:
FetchContentandExternalProject_Add.find_packagecalls and coverage flags to baseCMakeLists.txtinstead of adding them twice.