Skip to content

Clarify platform support of QuillEditorConfig.onKeyPressed #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

jaanus
Copy link
Contributor

@jaanus jaanus commented Apr 14, 2025

Description

The documentation stated that QuillEditorConfig.onKeyPressed is only supported by desktop devices. I found that it is also supported by mobile devices when they have a hardware keyboard connected, which is great, because I needed to customize some Quill editor behavior for exactly this scenario.

I modified the documentation of QuillEditorConfig.onKeyPressed to reflect this.

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

jaanus added 2 commits April 14, 2025 16:47
The documentation stated that this callback is only supported by desktop devices. I found that it is also supported by mobile devices when they have a hardware keyboard connected, which is great, because I needed to customize some Quill editor behavior for exactly this scenario.
@EchoEllet EchoEllet added the no changelog This pull request does not require an update to the changelog, as it does not introduce significant label Apr 14, 2025
@EchoEllet
Copy link
Collaborator

Thanks! We use APIs provided by Flutter, so the support depends on their implementation.

@EchoEllet EchoEllet merged commit 5d59de8 into singerdmx:master Apr 14, 2025
@jaanus jaanus deleted the patch-1 branch April 15, 2025 08:54
wangjinshan pushed a commit to wangjinshan/flutter-quill that referenced this pull request Apr 29, 2025
* master: (83 commits)
  Add copyWith methods to DefaultStyles, HorizontalSpacing, and VerticalSpacing (singerdmx#2550)
  docs: update migration guide to relfect singerdmx#2529
  chore(release): prepare to publish 11.4.0
  feat: allow to override link validation check, and accept mailto and other links by default (singerdmx#2525)
  chore(release): prepare to publish 11.3.0
  Fix selection in readOnly mode, Add magnifier via RawMagnifier widget (singerdmx#2529)
  Clarify platform support of QuillEditorConfig.onKeyPressed (singerdmx#2542)
  chore(release): prepare to publish 11.2.0
  feat: cache for toPlainText in Document to avoid unnecessary text computing (singerdmx#2482)
  chore(example): update deps
  chore(release): prepare to publish 11.1.2
  fix: QuillEditor doesn't respect the system keyboard brightness by default on iOS (singerdmx#2522)
  chore(release): prepare to publish flutter_quill_test
  chore(release): prepare to publish 11.1.1
  Chore: general improvements in flutter_quill_tests API (singerdmx#2512)
  Explicitly schedule frame on secondary click. (singerdmx#2507)
  chore(release): prepare to publish 11.1.0
  fix: unpredictable endless loop of '_handleFocusChanged' in the phase of page route changing when editor is set to readonly. (singerdmx#2488)
  feat: Enable BoxDecoration for DefaultTextBlockStyle of header Attribute (singerdmx#2438)
  Expose Rule type so that Document.setCustomRules can be used (singerdmx#2484)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not require an update to the changelog, as it does not introduce significant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants