Fix: Infinite loop when listen to FocusNode in read-only mode #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosue
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
CatHood0
changed the title
CatHood0
changed the title
CatHood0
changed the title
CatHood0
added
bug
… of page route changing when editor is set to readonly.
chaosue
force-pushed
the
master
branch
2 times, most recently
from
9d71e32 to
5ee4901
Compare
This comment was marked as resolved.
This comment was marked as resolved.
CatHood0
removed
the
awaiting response
CatHood0
pushed a commit
to CatHood0/flutter-quill
that referenced
this pull request
Mar 12, 2025
… of page route changing when editor is set to readonly. (singerdmx#2488) Co-authored-by: chaos <chaos@veigit.com>
2 tasks
wangjinshan
pushed a commit
to wangjinshan/flutter-quill
that referenced
this pull request
Apr 29, 2025
* master: (83 commits) Add copyWith methods to DefaultStyles, HorizontalSpacing, and VerticalSpacing (singerdmx#2550) docs: update migration guide to relfect singerdmx#2529 chore(release): prepare to publish 11.4.0 feat: allow to override link validation check, and accept mailto and other links by default (singerdmx#2525) chore(release): prepare to publish 11.3.0 Fix selection in readOnly mode, Add magnifier via RawMagnifier widget (singerdmx#2529) Clarify platform support of QuillEditorConfig.onKeyPressed (singerdmx#2542) chore(release): prepare to publish 11.2.0 feat: cache for toPlainText in Document to avoid unnecessary text computing (singerdmx#2482) chore(example): update deps chore(release): prepare to publish 11.1.2 fix: QuillEditor doesn't respect the system keyboard brightness by default on iOS (singerdmx#2522) chore(release): prepare to publish flutter_quill_test chore(release): prepare to publish 11.1.1 Chore: general improvements in flutter_quill_tests API (singerdmx#2512) Explicitly schedule frame on secondary click. (singerdmx#2507) chore(release): prepare to publish 11.1.0 fix: unpredictable endless loop of '_handleFocusChanged' in the phase of page route changing when editor is set to readonly. (singerdmx#2488) feat: Enable BoxDecoration for DefaultTextBlockStyle of header Attribute (singerdmx#2438) Expose Rule type so that Document.setCustomRules can be used (singerdmx#2484) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the property
readOnlyis set to true, typically in the read mode of contents, the UI tread may be stuck by endless loop when the route push back to the page with quill.The direct cause comes from the
_handleFocusChangedlistener, thefocusNodewill keep losing focus and requesting focus again instantly.The root cause hasn't been digged out, removing the unnecessary listeners in
readOnlymode can resolve the issue at the moment.Type of Change