Add Order.customAttributes and Order.number
#232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sgandhi1311
added a commit
that referenced
this pull request
Aug 5, 2025
* Initial commit for the shipping lines stream * update query * Add order_shipping_lines stream * Update changelog and bump version * Implement dynamic query builder * fix pylint and unit test * add retailLocation and DiscountCodeApplication fields to the orders schema * Update changelog * add location id in the orders.fulfillments * update pylint command * implement bulk query operation * working code * working code * Add requests module in the required * increase the poll time to 1 hour * Update logger statement and add date_window_size in the __init__ * set the max time limit for polling to 2 hours * Revert "Update logger statement and add date_window_size in the __init__" This reverts commit 4214f6f. * Add bulk operation ID in the logger statement * add wait time to 3 hours from 2 hours * fetch the last bulk operation id if it wasn't processed * fix pylint * add location and retail location back to the query * update wait time * Adjust the exceptions and few corner case scenarios * include unsupported fields as well * clear previous bulk id * customer specific, remove older bulk operation ID * update the order ID * Optimise query * include x-request-id in the log * Add new fields in the orders stream * update bulp op id * I have updated the poll wait time to 23 hours * add createdAt field in the fulfillments stream * display JSONL file size * Shopify claims that parent and child records will always be clubbed together * remove requests dependency as it's added in dev * update known missing field in the all fields test * add requests package as required * add customAttributes and number fields (#232) * setup and changelog changes * reduce the date window size for the bulk query operation to complete * clear previous bulk operation details if the date window size is modified * add custom message for the already bulk op running * remove orders from the few integration tests to save the time * make pylint happy * trying to reduce the circleci execution time * increase date window size for tests * remove orders from automatic test to save time --------- Co-authored-by: prijendev <prijen.khokhani@qlik.com> Co-authored-by: Robert Hill <30398720+rjh336@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following fields were missed on the order stream when migrating from REST to GraphQL so adding them back:
customAttributes(formerlynote_attributeson the REST order resource)number(formerlyorder_numberon the REST order resource)QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code