Skip to content

Conversation

rjh336
Copy link
Contributor

@rjh336 rjh336 commented Jul 10, 2025

Description of change

The following fields were missed on the order stream when migrating from REST to GraphQL so adding them back:

  • customAttributes (formerly note_attributes on the REST order resource)
  • number (formerly order_number on the REST order resource)

cc @sgandhi1311 @vishalp-dev @RushiT0122

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@sgandhi1311
Copy link
Member

Hello @rjh336
I don't see the number as a valid field in the GraphQL query.
Can you please create a branch from the branch - SAC-3256-bulk-query? And add the customAttributes field over there?

@rjh336
Copy link
Contributor Author

rjh336 commented Jul 28, 2025

Hi @sgandhi1311 - I will restage my changes on the SAC-3256-bulk-query branch. However, I will include the number field. I can query for it from the GQL API and was able to locally run the tap with it included. See it documented here: https://shopify.dev/docs/api/admin-graphql/latest/objects/order

image

@rjh336
Copy link
Contributor Author

rjh336 commented Jul 28, 2025

@sgandhi1311 see here #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants