Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache size becoming double of the defined size #13

Merged
merged 4 commits into from
May 29, 2019
Merged

Fix cache size becoming double of the defined size #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb67d3a
cache value is deleted from oldcache when moving
adityapatadia Apr 12, 2019
12e2815
tests added for #13
adityapatadia May 15, 2019
6cd42f9
Improve test
hong4rc May 15, 2019
21f9aa3
Merge pull request #1 from Hongarc/test
adityapatadia May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class QuickLRU {

if (this.oldCache.has(key)) {
const value = this.oldCache.get(key);
this.oldCache.delete(key);
this._set(key, value);
return value;
}
Expand Down
8 changes: 8 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,11 @@ test('.size - accounts for dupes', t => {
const lru = lruWithDuplicates();
t.is(lru.size, 2);
});

test('checks total cache size does not exceed maxSize', t => {
const lru = new QuickLRU({maxSize: 2});
lru.set('1', 1);
lru.set('2', 2);
lru.get('1');
t.is(lru.oldCache.has('1'), false);
});