Fix cache size becoming double of the defined size #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hong4rc
approved these changes
Apr 17, 2019
|
Can you add a test? |
|
The PR title could also be made clearer. It should describe what it fixes, not what was implemented. |
adityapatadia
changed the title
|
I have added tests. |
This test can't check your code |
|
@hongarc it would be great if you can elaborate this. |
Improve test
|
@hongarc thanks a lot for PR. |
|
I think this can be merged now. |
Just wait, he has too many pull requests need to review. |
|
I can see it on his profile 😁 |
sindresorhus
changed the title
|
Looks good. Thank you @adityapatadia :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #10