Skip to content

fix(text-fields): prevent save password on usage limit change #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Jul 11, 2025
Merged

fix(text-fields): prevent save password on usage limit change #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee7184
prevent save password on usage limit change
waleedlatif1 Jul 11, 2025
46e9070
prevent more password managers from appearing
waleedlatif1 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/sim/app/workspace/[workspaceId]/knowledge/components/create-modal/create-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,9 @@ export function CreateModal({ open, onOpenChange, onKnowledgeBaseCreated }: Crea
placeholder='100'
{...register('minChunkSize', { valueAsNumber: true })}
className={errors.minChunkSize ? 'border-red-500' : ''}
autoComplete='off'
data-form-type='other'
name='min-chunk-size'
/>
{errors.minChunkSize && (
<p className='mt-1 text-red-500 text-xs'>{errors.minChunkSize.message}</p>
Expand All @@ -444,6 +447,9 @@ export function CreateModal({ open, onOpenChange, onKnowledgeBaseCreated }: Crea
placeholder='1024'
{...register('maxChunkSize', { valueAsNumber: true })}
className={errors.maxChunkSize ? 'border-red-500' : ''}
autoComplete='off'
data-form-type='other'
name='max-chunk-size'
/>
{errors.maxChunkSize && (
<p className='mt-1 text-red-500 text-xs'>{errors.maxChunkSize.message}</p>
Expand All @@ -460,6 +466,9 @@ export function CreateModal({ open, onOpenChange, onKnowledgeBaseCreated }: Crea
placeholder='200'
{...register('overlapSize', { valueAsNumber: true })}
className={errors.overlapSize ? 'border-red-500' : ''}
autoComplete='off'
data-form-type='other'
name='overlap-size'
/>
{errors.overlapSize && (
<p className='mt-1 text-red-500 text-xs'>{errors.overlapSize.message}</p>
Expand Down
6 changes: 6 additions & 0 deletions ...]/w/[workflowId]/components/workflow-block/components/sub-block/components/eval-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ export function EvalInput({
onBlur={(e) => handleRangeBlur(metric.id, 'min', e.target.value)}
disabled={isPreview || disabled}
className='placeholder:text-muted-foreground/50'
autoComplete='off'
data-form-type='other'
name='eval-range-min'
/>
</div>
<div className='space-y-1'>
Expand All @@ -203,6 +206,9 @@ export function EvalInput({
onBlur={(e) => handleRangeBlur(metric.id, 'max', e.target.value)}
disabled={isPreview || disabled}
className='placeholder:text-muted-foreground/50'
autoComplete='off'
data-form-type='other'
name='eval-range-max'
/>
</div>
</div>
Expand Down
9 changes: 9 additions & 0 deletions ...nts/workflow-block/components/sub-block/components/schedule/components/schedule-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,9 @@ export function ScheduleModal({
type='number'
min='1'
className='h-10'
autoComplete='off'
data-form-type='other'
name='minutes-interval'
/>
</div>
)}
Expand All @@ -455,6 +458,9 @@ export function ScheduleModal({
min='0'
max='59'
className='h-10'
autoComplete='off'
data-form-type='other'
name='hourly-minute'
/>
<p className='text-muted-foreground text-xs'>
Specify which minute of each hour the workflow should run (0-59)
Expand Down Expand Up @@ -530,6 +536,9 @@ export function ScheduleModal({
min='1'
max='31'
className='h-10'
autoComplete='off'
data-form-type='other'
name='monthly-day'
/>
<p className='text-muted-foreground text-xs'>
Specify which day of the month the workflow should run (1-31)
Expand Down
3 changes: 3 additions & 0 deletions ...components/settings-modal/components/subscription/components/edit-member-limit-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ export function EditMemberLimitDialog({
max={10000}
step='1'
placeholder={planMinimum.toString()}
autoComplete='off'
data-form-type='other'
name='member-usage-limit'
/>
</div>
<p className='text-muted-foreground text-xs'>
Expand Down
3 changes: 3 additions & 0 deletions ...debar/components/settings-modal/components/subscription/components/usage-limit-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ export function UsageLimitEditor({
min={minimumLimit}
step='1'
disabled={isSaving}
autoComplete='off'
data-form-type='other'
name='usage-limit'
/>
) : (
<span className='font-medium text-sm'>{currentLimit}</span>
Expand Down