Skip to content

fix(text-fields): prevent save password on usage limit change#667

Merged
waleedlatif1 merged 2 commits intostagingfrom
fix/sub-ui
Jul 11, 2025
Merged

fix(text-fields): prevent save password on usage limit change#667
waleedlatif1 merged 2 commits intostagingfrom
fix/sub-ui

Conversation

@waleedlatif1
Copy link
Collaborator

Description

Prevent save password on usage limit change

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually by updating amount and ensured password manager did not appear

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 3:12am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 11, 2025 3:12am

@delve-auditor
Copy link

delve-auditor bot commented Jul 11, 2025

No security or compliance issues detected. Reviewed everything up to 46e9070.

Security Overview
  • 🔎 Scanned files: 5 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► create-modal.tsx
    Add input attributes for form fields
► eval-input.tsx
    Add input attributes for eval range fields
► schedule-modal.tsx
    Add input attributes for schedule fields
► edit-member-limit-dialog.tsx
    Add input attributes for member limit field
► usage-limit-editor.tsx
    Add input attributes for usage limit field

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added attributes to prevent password manager interference on numeric input fields across multiple components.

  • Added autoComplete='off', data-form-type='other' to knowledge base configuration fields in apps/sim/app/workspace/[workspaceId]/knowledge/components/create-modal/create-modal.tsx
  • Applied password manager prevention attributes to schedule-related inputs in schedule-modal.tsx for minutes-interval, hourly-minute, and monthly-day fields
  • Enhanced member limit and usage limit inputs in subscription-related components to prevent unwanted password manager suggestions
  • Protected metric range inputs in eval-input.tsx from triggering password manager prompts

5 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit e216b17 into staging Jul 11, 2025
6 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/sub-ui branch July 11, 2025 03:15
@waleedlatif1 waleedlatif1 mentioned this pull request Jul 13, 2025
18 tasks
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…dioai#667)

* prevent save password on usage limit change

* prevent more password managers from appearing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant