fix(text-fields): prevent save password on usage limit change#667
Merged
waleedlatif1 merged 2 commits intostagingfrom Jul 11, 2025
Merged
fix(text-fields): prevent save password on usage limit change#667waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 46e9070. Security Overview
Detected Code Changes
Reply to this PR with |
Contributor
There was a problem hiding this comment.
PR Summary
Added attributes to prevent password manager interference on numeric input fields across multiple components.
- Added
autoComplete='off',data-form-type='other'to knowledge base configuration fields inapps/sim/app/workspace/[workspaceId]/knowledge/components/create-modal/create-modal.tsx - Applied password manager prevention attributes to schedule-related inputs in
schedule-modal.tsxfor minutes-interval, hourly-minute, and monthly-day fields - Enhanced member limit and usage limit inputs in subscription-related components to prevent unwanted password manager suggestions
- Protected metric range inputs in
eval-input.tsxfrom triggering password manager prompts
5 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
apps/sim/app/workspace/[workspaceId]/knowledge/components/create-modal/create-modal.tsx
Show resolved
Hide resolved
...onents/workflow-block/components/sub-block/components/schedule/components/schedule-modal.tsx
Show resolved
Hide resolved
18 tasks
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
…dioai#667) * prevent save password on usage limit change * prevent more password managers from appearing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent save password on usage limit change
Type of change
How Has This Been Tested?
Tested manually by updating amount and ensured password manager did not appear
Checklist:
bun run test)Security Considerations: