Merged
Conversation
* fix alignment of buttons on landing page * revert environment.ts * revert other change
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Fixed visual alignment of pricing plan cards by equalizing feature counts across tiers:
- Removed "Community support" from Free plan (reduced from 6 to 5 features)
- Removed "Unlimited workflows" from Pro plan (reduced from 7 to 6 features)
- Cleaned up unused icon imports (
Usersfrom landing-pricing.tsx,Workflowfrom plan-configs.ts)
The changes maintain feature parity between the landing page and settings modal by keeping them synchronized through the shared plan-configs.ts configuration file, following the established pattern of separating configuration from presentation.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The changes are purely cosmetic, removing feature list items to fix visual alignment issues. No logic, types, or functionality were modified. The unused imports were properly cleaned up, and the changes maintain consistency between the landing page and settings modal through the shared configuration file.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/subscription/plan-configs.ts | 5/5 | Removed "Unlimited workflows" feature from Pro plan and cleaned up unused Workflow import |
| apps/sim/app/(landing)/components/landing-pricing/landing-pricing.tsx | 5/5 | Removed "Community support" feature from Free plan and cleaned up unused Users import |
Sequence Diagram
sequenceDiagram
participant User
participant LandingPricing
participant PlanConfigs
participant PricingCard
User->>LandingPricing: Views pricing page
LandingPricing->>PlanConfigs: Import PRO_PLAN_FEATURES
Note over PlanConfigs: Features: 6 items<br/>(removed "Unlimited workflows")
PlanConfigs-->>LandingPricing: Return 6 Pro features
LandingPricing->>LandingPricing: Define FREE_PLAN_FEATURES
Note over LandingPricing: Features: 5 items<br/>(removed "Community support")
LandingPricing->>PricingCard: Render Free plan (5 features)
LandingPricing->>PricingCard: Render Pro plan (6 features)
LandingPricing->>PricingCard: Render Team plan
LandingPricing->>PricingCard: Render Enterprise plan
PricingCard-->>User: Display aligned pricing cards
2 files reviewed, no comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(landing): plans alignment broken (#1696)