Skip to content

fix(plan-config): align buttons above divider#1696

Merged
icecrasher321 merged 3 commits intostagingfrom
fix/landing-pg-alignment
Oct 19, 2025
Merged

fix(plan-config): align buttons above divider#1696
icecrasher321 merged 3 commits intostagingfrom
fix/landing-pg-alignment

Conversation

@icecrasher321
Copy link
Collaborator

Summary

Landing page plans went out of alignment after adding line on storage.

Type of Change

  • Bug fix

Testing

Screenshot 2025-10-19 at 3 57 02 PM

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Oct 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Oct 19, 2025 11:00pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@icecrasher321 icecrasher321 merged commit ce660e2 into staging Oct 19, 2025
3 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

Fixed landing page pricing button alignment by equalizing feature counts across plans and applying auto-rows-fr grid layout.

Major Issues:

  • CRITICAL: apps/sim/lib/environment.ts contains hardcoded environment values (isProd = true, isDev = false, isTest = false) that will break all development and testing environments
  • The isHosted logic was also changed from URL-based detection to environment variable-based detection

Pricing Changes:

  • Removed "Community support" from Free plan (6→5 features)
  • Removed "Unlimited workflows" from Pro plan (7→6 features)
  • Added auto-rows-fr to grid to ensure equal row heights

Confidence Score: 0/5

  • This PR is NOT safe to merge - contains critical breaking changes to environment detection
  • The hardcoded environment values in environment.ts will cause all environments to behave as production, breaking development workflows, testing infrastructure, and environment-specific logic throughout the application
  • apps/sim/lib/environment.ts must be reverted to use env.NODE_ENV checks before merging

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/lib/environment.ts 0/5 Critical bug: hardcoded environment values break all non-production environments
apps/sim/app/(landing)/components/landing-pricing/landing-pricing.tsx 5/5 Fixed button alignment by removing one feature item and adding auto-rows-fr grid class
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/subscription/plan-configs.ts 5/5 Removed "Unlimited workflows" feature to equalize feature counts across plans

Sequence Diagram

sequenceDiagram
    participant User
    participant LandingPricing
    participant PlanConfigs
    participant Environment
    
    User->>LandingPricing: View pricing page
    LandingPricing->>PlanConfigs: Import PRO/TEAM/ENTERPRISE features
    PlanConfigs-->>LandingPricing: Return feature arrays (6 items each)
    LandingPricing->>LandingPricing: Render FREE plan (5 items)
    LandingPricing->>LandingPricing: Apply auto-rows-fr grid layout
    LandingPricing-->>User: Display aligned pricing cards
    
    Note over Environment: CRITICAL: Hardcoded values break<br/>environment detection in all contexts
Loading

Additional Comments (1)

  1. apps/sim/lib/environment.ts, line 9-19 (link)

    logic: hardcoded environment values will break development and testing - all environments will be treated as production

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 deleted the fix/landing-pg-alignment branch November 6, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant