fix(plan-config): align buttons above divider#1696
Merged
icecrasher321 merged 3 commits intostagingfrom Oct 19, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Fixed landing page pricing button alignment by equalizing feature counts across plans and applying auto-rows-fr grid layout.
Major Issues:
- CRITICAL:
apps/sim/lib/environment.tscontains hardcoded environment values (isProd = true,isDev = false,isTest = false) that will break all development and testing environments - The
isHostedlogic was also changed from URL-based detection to environment variable-based detection
Pricing Changes:
- Removed "Community support" from Free plan (6→5 features)
- Removed "Unlimited workflows" from Pro plan (7→6 features)
- Added
auto-rows-frto grid to ensure equal row heights
Confidence Score: 0/5
- This PR is NOT safe to merge - contains critical breaking changes to environment detection
- The hardcoded environment values in
environment.tswill cause all environments to behave as production, breaking development workflows, testing infrastructure, and environment-specific logic throughout the application - apps/sim/lib/environment.ts must be reverted to use
env.NODE_ENVchecks before merging
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/lib/environment.ts | 0/5 | Critical bug: hardcoded environment values break all non-production environments |
| apps/sim/app/(landing)/components/landing-pricing/landing-pricing.tsx | 5/5 | Fixed button alignment by removing one feature item and adding auto-rows-fr grid class |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/subscription/plan-configs.ts | 5/5 | Removed "Unlimited workflows" feature to equalize feature counts across plans |
Sequence Diagram
sequenceDiagram
participant User
participant LandingPricing
participant PlanConfigs
participant Environment
User->>LandingPricing: View pricing page
LandingPricing->>PlanConfigs: Import PRO/TEAM/ENTERPRISE features
PlanConfigs-->>LandingPricing: Return feature arrays (6 items each)
LandingPricing->>LandingPricing: Render FREE plan (5 items)
LandingPricing->>LandingPricing: Apply auto-rows-fr grid layout
LandingPricing-->>User: Display aligned pricing cards
Note over Environment: CRITICAL: Hardcoded values break<br/>environment detection in all contexts
Additional Comments (1)
-
apps/sim/lib/environment.ts, line 9-19 (link)logic: hardcoded environment values will break development and testing - all environments will be treated as production
3 files reviewed, 1 comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Landing page plans went out of alignment after adding line on storage.
Type of Change
Testing
Checklist