fix(condition-block): edges not following blocks, duplicate issues

[icecrasher321]

Summary

• Moving the subblocks around did not transfer edges along with it
• Duplication was not working with condition blocks.

Type of Change

• Bug fix

Testing

Screen.Recording.2025-08-26.at.7.41.47.PM.mov

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
sim	Error			Aug 27, 2025 2:53am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Aug 27, 2025 2:53am

[greptile-apps]

Greptile Summary

This PR fixes two critical bugs with condition blocks in the workflow system: edges not following subblocks when moved, and duplication functionality not working properly.

The fix involves three key changes:

1. Collaborative Workflow Enhancement (use-collaborative-workflow.ts): Added logic to handle subblock values during block duplication operations. When a 'duplicate' operation is received, the code now extracts subblock values from the payload and immediately applies them using subBlockStore.setValue(), ensuring that collaborators see the duplicated block's content immediately rather than empty subblocks.

2. Workflow Registry Initialization (store.ts): Added a call to useSubBlockStore.getState().initializeFromWorkflow() in the setActiveWorkflow method. This ensures subblock values are properly initialized when switching to a workflow, following the same pattern used in other workflow creation methods.

3. Condition Block Persistence Control (condition-input.tsx): Implemented a comprehensive persistence control mechanism using a shouldPersistRef to prevent premature store updates during initialization phases. The solution includes proper edge cleanup when blocks are removed, constraints to prevent invalid operations on 'else' blocks, and ensures React Flow updates node connections via updateNodeInternals() calls.

These changes work together to maintain the integrity of condition block structures and their associated connections throughout the workflow editing process, ensuring that both local and collaborative editing operations preserve the block-edge relationships correctly.

Confidence score: 4/5

• This PR addresses specific, well-identified bugs with targeted fixes that follow established patterns in the codebase
• Score reflects solid implementation but includes type assertions and complex state management that could benefit from additional testing
• Pay close attention to the condition-input.tsx file due to its complex persistence logic and edge cleanup mechanisms

Context used:

Context - Avoid using type assertions to 'any' in TypeScript. Instead, ensure proper type definitions are used to maintain type safety. (link)

_{3 files reviewed, 2 comments}

_{Edit Code Review Bot Settings | Greptile}