improvement(forwarding+excel): added forwarding and improve excel read by aadamgough · Pull Request #1136 · simstudioai/sim

aadamgough · 2025-08-26T06:37:57Z

Summary

Added forward email in outlook and improved reading excel sheets when user inputs no range.

Type of Change

New feature

Testing

Tested by forwarding emails to different addresses. Tested by adding excel sheets without ranges and just the excel sheet name.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Screen.Recording.2025-08-26.at.4.30.45.PM.mov

vercel · 2025-08-26T06:38:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Ready	Preview	Comment	Aug 27, 2025 3:32am
sim	Ready	Preview	Comment	Aug 27, 2025 3:32am

greptile-apps

Greptile Summary

This PR adds email forwarding functionality to the Outlook integration, completing the email management capabilities alongside existing send, draft, and read operations. The implementation follows established patterns in the codebase by creating a new outlookForwardTool that integrates with Microsoft Graph API's forward endpoint.

The changes span multiple layers of the architecture:

Core tool implementation: A new forward.ts file defines the tool configuration with OAuth authentication, parameter validation, and API integration
Type definitions: New interfaces OutlookForwardParams and OutlookForwardResponse extend the existing Outlook type system
Block integration: The Outlook block configuration now includes a "Forward Email" operation with conditional input fields for message ID and optional comments
Registry updates: The new tool is properly registered in both the tools index and main registry for discoverability
Infrastructure improvements: Enhanced error handling in the core request handler to support Microsoft Graph API's HTTP 202 responses for async operations

The forward tool requires a messageId to identify the email to forward, recipient email addresses in the to parameter, and accepts an optional comment to include with the forwarded message. The implementation uses the same OAuth provider (outlook) and follows the consistent ToolConfig pattern used throughout the email tools.

Additionally, the PR includes an unrelated improvement to the Microsoft Excel read tool, adding support for sheet-only range inputs (e.g., Sheet1 without explicit cell ranges) and fixes an inconsistency in the Outlook read tool's output schema to align with its actual response format.

Confidence score: 3/5

This PR has several implementation issues that need attention before merging
Score reflects concerns about response handling inconsistencies and missing validation in the forward tool
Pay close attention to apps/sim/tools/outlook/forward.ts for response structure mismatches and error handling gaps

_{8 files reviewed, 5 comments}

_{Edit Code Review Bot Settings | Greptile}

apps/sim/tools/outlook/types.ts

apps/sim/tools/outlook/index.ts

apps/sim/tools/index.ts

apps/sim/tools/outlook/forward.ts

icecrasher321 · 2025-08-27T01:28:49Z

apps/sim/tools/index.ts


 const logger = createLogger('Tools')

+// Extract a concise, meaningful error message from diverse API error shapes


do we need this?

ah nvm this is the same thing as existing code I think

icecrasher321 · 2025-08-27T01:29:57Z

apps/sim/tools/index.ts

      logger.error(`[${requestId}] Internal API error for ${toolId}:`, {
-        status: errorInfo?.status,
-        errorData: errorInfo?.data,
+        status: (errorToTransform as any).status,


we shouldn't move towards any typing....why are we making these changes?

icecrasher321 · 2025-08-27T03:14:35Z

apps/sim/lib/webhooks/outlook-polling-service.ts

  rawEmail?: OutlookEmail // Only included when includeRawEmail is true
 }

+/**


can we use a library func for this....doing this ourselves is almost certainly going to break something

yeah changing rn

#1136) * added forwarding for outlook * lint * improved excel sheet read * addressed greptile * fixed bodytext getting truncated * fixed any type * added html func --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>

…is for queueing docs in kb (#1143) * improvement(kb): created knowledge, chunks, tags services and use redis for queueing docs in kb * moved directories around * cleanup * bulk create docuemnt records after upload is completed * fix(copilot): send api key to sim agent (#1142) * Fix api key auth * Lint * ack PR comments * added sort by functionality for headers in kb table * updated * test fallback from redis, fix styling * cleanup copilot, fixed tooltips * feat: local auto layout (#1144) * feat: added llms.txt and robots.txt (#1145) * fix(condition-block): edges not following blocks, duplicate issues (#1146) * fix(condition-block): edges not following blocks, duplicate issues * add subblock update to setActiveWorkflow * Update apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/condition-input.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix dependency array * fix(copilot-cleanup): support azure blob upload in copilot, remove dead code & consolidate other copilot files (#1147) * cleanup * support azure blob image upload * imports cleanup * PR comments * ack PR comments * fix key validation * improvement(forwarding+excel): added forwarding and improve excel read (#1136) * added forwarding for outlook * lint * improved excel sheet read * addressed greptile * fixed bodytext getting truncated * fixed any type * added html func --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> * revert agent const * update docs --------- Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>

simstudioai#1136) * added forwarding for outlook * lint * improved excel sheet read * addressed greptile * fixed bodytext getting truncated * fixed any type * added html func --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>

…is for queueing docs in kb (simstudioai#1143) * improvement(kb): created knowledge, chunks, tags services and use redis for queueing docs in kb * moved directories around * cleanup * bulk create docuemnt records after upload is completed * fix(copilot): send api key to sim agent (simstudioai#1142) * Fix api key auth * Lint * ack PR comments * added sort by functionality for headers in kb table * updated * test fallback from redis, fix styling * cleanup copilot, fixed tooltips * feat: local auto layout (simstudioai#1144) * feat: added llms.txt and robots.txt (simstudioai#1145) * fix(condition-block): edges not following blocks, duplicate issues (simstudioai#1146) * fix(condition-block): edges not following blocks, duplicate issues * add subblock update to setActiveWorkflow * Update apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/sub-block/components/condition-input.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix dependency array * fix(copilot-cleanup): support azure blob upload in copilot, remove dead code & consolidate other copilot files (simstudioai#1147) * cleanup * support azure blob image upload * imports cleanup * PR comments * ack PR comments * fix key validation * improvement(forwarding+excel): added forwarding and improve excel read (simstudioai#1136) * added forwarding for outlook * lint * improved excel sheet read * addressed greptile * fixed bodytext getting truncated * fixed any type * added html func --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> * revert agent const * update docs --------- Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>

added forwarding for outlook

19e68aa

lint

b103faa

vercel bot temporarily deployed to Preview – docs August 26, 2025 18:55 Inactive

vercel bot deployed to Preview – sim August 26, 2025 18:59 View deployment

improved excel sheet read

f2a021f

vercel bot temporarily deployed to Preview – docs August 26, 2025 20:15 Inactive

vercel bot deployed to Preview – sim August 26, 2025 20:19 View deployment

aadamgough marked this pull request as ready for review August 26, 2025 20:51

greptile-apps bot reviewed Aug 26, 2025

View reviewed changes

addressed greptile

150c51e

vercel bot temporarily deployed to Preview – docs August 26, 2025 21:03 Inactive

aadamgough changed the title ~~improvement(forwarding): added forwarding for outlook~~ improvement(forwarding+excel): added forwarding and improve excel read Aug 26, 2025

vercel bot deployed to Preview – sim August 26, 2025 21:07 View deployment

icecrasher321 reviewed Aug 27, 2025

View reviewed changes

fixed bodytext getting truncated

e997365

vercel bot temporarily deployed to Preview – docs August 27, 2025 03:11 Inactive

fixed any type

cddb39a

vercel bot temporarily deployed to Preview – docs August 27, 2025 03:13 Inactive

icecrasher321 reviewed Aug 27, 2025

View reviewed changes

vercel bot deployed to Preview – sim August 27, 2025 03:18 View deployment

added html func

a4d274d

vercel bot deployed to Preview – docs August 27, 2025 03:28 View deployment

vercel bot deployed to Preview – sim August 27, 2025 03:32 View deployment

icecrasher321 merged commit ab74b13 into staging Aug 27, 2025
5 checks passed

waleedlatif1 deleted the improvement/outlook branch August 27, 2025 06:12

waleedlatif1 mentioned this pull request Aug 28, 2025

v0.3.40: copilot improvements, knowledgebase improvements, security improvements, billing fixes #1158

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improvement(forwarding+excel): added forwarding and improve excel read#1136

improvement(forwarding+excel): added forwarding and improve excel read#1136
icecrasher321 merged 7 commits intostagingfrom
improvement/outlook

aadamgough commented Aug 26, 2025 •

edited

Loading

Uh oh!

vercel bot commented Aug 26, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 Aug 27, 2025

Uh oh!

icecrasher321 Aug 27, 2025

Uh oh!

aadamgough Aug 27, 2025

Uh oh!

icecrasher321 Aug 27, 2025

Uh oh!

icecrasher321 Aug 27, 2025

Uh oh!

aadamgough Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		const logger = createLogger('Tools')

		// Extract a concise, meaningful error message from diverse API error shapes

Conversation

aadamgough commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Screenshots/Videos

Uh oh!

vercel bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Summary

Confidence score: 3/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

icecrasher321 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

aadamgough Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

icecrasher321 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

icecrasher321 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

aadamgough Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aadamgough commented Aug 26, 2025 •

edited

Loading

vercel bot commented Aug 26, 2025 •

edited

Loading